Improve 'no such linter' error message #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
iwankgb
reviewed
Jul 16, 2020
|
@iwankgb actually here is no difference at this moment. But if for Validator struct will be added some struct fields then pointer receivers will be better :) |
|
We should not anticipate future code changes, I believe. Would you be OK with reverting to value receivers? |
sayboras
reviewed
Jul 16, 2020
sayboras
reviewed
Jul 16, 2020
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
iwankgb
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Steps to reproduce
Actual: Printed err msg 'no such linter %v' for all new linters which was added since 1.26. The error message looks is not clear for new users. The message can confuse the user like 'Should I download missed linter?'.
I think we need to point that the user can run
golangci-lint lintersto see supported linter list of hisgolangci-lintertool.