Skip to content

Update godot linter #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Update godot linter #1050

merged 1 commit into from
Apr 30, 2020

Conversation

tetafro
Copy link

@tetafro tetafro commented Apr 28, 2020

Fix checking #gosec in comments

@tetafro
Copy link
Author

tetafro commented Apr 29, 2020

Finally fixed it, but with a dirty hack.

@ernado hi, maybe you can help. I have a problems with detecting cgo code blocks, and I don't even see import "C" inside analysis.Pass.File[].Imports. Do know any trick to get this info?

@ernado
Copy link
Member

ernado commented Apr 30, 2020

Seems like your solution for cgo is good, so let's stick with it.

@ernado ernado merged commit 49b3993 into golangci:master Apr 30, 2020
@ldez ldez added the linter: update version Update version of linter label Dec 7, 2020
@ldez ldez added this to the v1.26 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linter: update version Update version of linter
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@tetafro @ernado @ldez