Bool Alias: comparison to bool constant

[awesee]

Thank you for creating the issue!

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc).

Please include the following information:

Version of golangci-lint

$ golangci-lint --version
golangci-lint has version 1.20.1 built from 849044b on 2019-10-15T19:11:27Z

Config file

$ cat .golangci.yml
cat: .golangci.yml: No such file or directory

Go environment

$ go version && go env
go version go1.13.4 darwin/amd64
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/Users/Shuo/go/bin"
GOCACHE="/Users/Shuo/Library/Caches/go-build"
GOENV="/Users/Shuo/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/Shuo/go"
GOPRIVATE=""
GOPROXY="https://goproxy.io"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r_/kfg_zdzx05qgnd5_wfrrr_l00000gn/T/go-build967944465=/tmp/go-build -gno-record-gcc-switches -fno-common"

Verbose output of running

$ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /Users/Shuo/openset/leetcode/internal/description /Users/Shuo/openset/leetcode/internal /Users/Shuo/openset/leetcode /Users/Shuo/openset /Users/Shuo /Users /] 
INFO [lintersdb] Active 10 linters: [deadcode errcheck gosimple govet ineffassign staticcheck structcheck typecheck unused varcheck] 
INFO [loader] Go packages loading at mode 575 (files|imports|name|types_sizes|compiled_files|deps|exports_file) took 419.885783ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 433.256µs 
INFO [runner] Processors filtering stat (out/in): max_per_file_from_linter: 1/1, max_from_linter: 1/1, path_shortener: 1/1, filename_unadjuster: 1/1, path_prettifier: 1/1, skip_dirs: 1/1, nolint: 1/1, cgo: 1/1, skip_files: 1/1, identifier_marker: 1/1, exclude: 1/1, diff: 1/1, max_same_issues: 1/1, source_code: 1/1, autogenerated_exclude: 1/1, exclude-rules: 1/1, uniq_by_line: 1/1 
INFO [runner] processing took 585.727µs with stages: nolint: 159.943µs, source_code: 132.447µs, exclude: 78.448µs, path_prettifier: 77.795µs, autogenerated_exclude: 63.181µs, identifier_marker: 35.112µs, skip_dirs: 13.96µs, filename_unadjuster: 13.125µs, uniq_by_line: 4.127µs, max_same_issues: 2.137µs, cgo: 1.713µs, path_shortener: 1.533µs, max_from_linter: 1.015µs, max_per_file_from_linter: 484ns, exclude-rules: 258ns, skip_files: 240ns, diff: 209ns 
INFO [runner] linters took 336.921437ms with stages: goanalysis_metalinter: 214.262917ms, unused: 121.955562ms 
internal/description/description.go:43:32: S1002: should omit comparison to bool constant, can be simplified to `problem.PaidOnly` (gosimple)
                if question.Content == "" && problem.PaidOnly == true && problem.Stat.QuestionArticleLive {
                                             ^
INFO File cache stats: 1 entries of total size 1.3KiB 
INFO Memory: 9 samples, avg is 68.9MB, max is 68.9MB 
INFO Execution took 781.125715ms       

[awesee]

package main

import "fmt"

type B bool

func (b B) Val() bool {
	// code like this can be simplified to `bool(b)`, not `b`
	return b == true
}

func (b B) String() string {
	if b {
		return "true"
	}
	return "false"
}

func main() {
	var b B
	// code like this can be simplified to `bool(b)`, not `b`
	// this may be ok, not need simplify. `foo.bar.bool.val == true` VS `bool(foo.bar.bool.val)`
	if b == true && fb() {
		fmt.Println("this is true")
	} else {
		fmt.Println("this is false")
	}
}

func fb() bool {
	return false
}

[tpounds]

@openset Thanks for the report. In the provided examples are you saying 1. it's not returning an error when it should, 2. returning an error when it should not, or 3. returning an error with the wrong message?

[awesee]

@tpounds returning an error when it should not

$ golangci-lint run main.go 

main.go:9:9: S1002: should omit comparison to bool constant, can be simplified to `b` (gosimple)
        return b == true
               ^
main.go:23:5: S1002: should omit comparison to bool constant, can be simplified to `b` (gosimple)
        if b == true && fb() {
           ^

[tpounds]

@openset Thanks for the additional info. I was able to reproduce the issue you have described, unfortunately, gosimple's detection logic is implemented as part of the Staticcheck analyzers suite. I think the best path forward is to add //nolint directives to suppress the warnings as necessary and report the issue to the upstream project to change the behavior.