go1.17 arm64 fails with can't load fmt error (>= 1.45.0)

[drew-richardson]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc).
• Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

golangci-lint version 1.45.0 on linux arm64/aarch64 with go1.17.8 fails with this error

panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488

golangci-lint version 1.45.0 works just fine on amd64 with go1.17.8, as well as arm64 with go1.18

Here's the whole process

$ docker run -it --rm --entrypoint /bin/bash golang:1.17
root@eb266021b73c:/go# uname -m
aarch64
root@eb266021b73c:/go# go version
go version go1.17.8 linux/arm64
root@eb266021b73c:/go# curl -SsLO https://github.com/golangci/golangci-lint/releases/download/v1.45.0/golangci-lint-1.45.0-linux-arm64.tar.gz
root@eb266021b73c:/go# tar -xf golangci-lint-1.45.0-linux-arm64.tar.gz
root@eb266021b73c:/go# golangci-lint-1.45.0-linux-arm64/golangci-lint
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488
root@eb266021b73c:/go# 

Version of golangci-lint

root@eb266021b73c:/go# golangci-lint-1.45.0-linux-arm64/golangci-lint --version
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488
root@eb266021b73c:/go# 

Configuration file

root@eb266021b73c:/go# cat .golangci.yml
cat: .golangci.yml: No such file or directory
root@eb266021b73c:/go# 

Go environment

root@eb266021b73c:/go# go version && go env
go version go1.17.8 linux/arm64
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_arm64"
GOVCS=""
GOVERSION="go1.17.8"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build850424411=/tmp/go-build -gno-record-gcc-switches"
root@eb266021b73c:/go# 

Verbose output of running

root@eb266021b73c:/go# golangci-lint-1.45.0-linux-arm64/golangci-lint cache clean
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488
root@eb266021b73c:/go# golangci-lint-1.45.0-linux-arm64/golangci-lint run -v
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488
root@eb266021b73c:/go# 

Code example or link to a public repository

N/A error occurs before running the linters, no code is being linted

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[4meepo]

I have the same issue on darwin arm64.

[ldez]

@WorkerYifei you have the same kind of problem, ok, but could you provide more information about your context?

• Are you using the Docker image, an official binary, a custom binary?
• which version of Go are you using?
• what is your configuration?
• can you provide a reproducible example?
• have you tried with the go-critic binary?

To help, it's important to provide more and new information when you comment on an issue.

[4meepo]

@ldez Sorry for the late reply.

• Are you using the Docker image, an official binary, a custom binary?

I'm using the 1.45.2-darwin-arm64 official binary on my Mac mini M1.

• which version of Go are you using?

go1.17.7

• what is your configuration?

N/A

• can you provide a reproducible example?

I think it's not related to my code. I can't even run the version command.

• have you tried with the go-critic binary?

I'm not familiar with go-critic,but I think it works fine on my mac. See the snapshot below:

I hope it helps.

[4meepo]

By the way, It works good on my Mac with Intel chip when environment and configuration not changed.

[andreas-hakansson-ingka]

I'm seeing the same issue with Go 1.17.6 and golangci-lint 1.45.2 and 1.45.0 on M1 MBP

panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
	github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x494
make: *** [lint] Error 2

Works fine if I downgrade to 1.44.2

[fraenky8]

We are facing same issue but on CircleCI with Linux based Dockerfile. I played around and downgrading to 1.45.0 seem to help. Copying here the setup step from CircleCI, maybe it helps:

Build-agent version 1.0.117314-02cfb3b4 (2022-03-29T08:17:31+0000)
System information:
 Server Version: 20.10.12
 Storage Driver: overlay2
  Backing Filesystem: xfs
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Kernel Version: 5.13.0-1017-aws
 Operating System: Ubuntu 20.04.4 LTS
 OSType: linux
 Architecture: x86_64

Starting container cimg/go:1.18
...

[mortezaalizadeh]

Having same problem here, look at this pipeline:

https://github.com/coincode-live/prototype/runs/5831984242?check_suite_focus=true

[ldez]

@mortezaalizadeh form your logs:

Operating System
Ubuntu
20.04.4
LTS
Requested golangci-lint 'v1.44', using 'v1.44.2', calculation took 205ms
Installing golangci-lint v1.44.2...

This issue is about 1.45.x on Darwin arm64.

Your problem is related to something else, it's a problem with go-critic in some conditions go-critic/go-critic#1218

[ldemailly]

Any update? (not quite same as #2374)

On arm (m1) with golang 1.17.9 1.44.2 works, 1.45.2 doesn't:

$ docker build -f Dockerfile.lint_bug  .
[+] Building 13.7s (7/7) FINISHED                                                                                                                                                                                          
 => [internal] load build definition from Dockerfile.lint_bug                                                                                                                                                         0.0s
 => => transferring dockerfile: 411B                                                                                                                                                                                  0.0s
 => [internal] load .dockerignore                                                                                                                                                                                     0.0s
 => => transferring context: 2B                                                                                                                                                                                       0.0s
 => [internal] load metadata for docker.io/library/golang:1.17.9                                                                                                                                                      2.3s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                                                                                         0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.17.9@sha256:c1bf2101f7e1e0b08ce8f792735a81cd71b9d81cbcdceef2382140694f1ffbaf                                                                                         0.0s
 => [2/3] RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.45.2                                                                        6.0s
 => ERROR [3/3] RUN golangci-lint version                                                                                                                                                                             5.3s
------                                                                                                                                                                                                                     
 > [3/3] RUN golangci-lint version:                                                                                                                                                                                        
#7 5.277 panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
#7 5.277 
#7 5.277 goroutine 1 [running]:
#7 5.277 github.com/go-critic/go-critic/checkers.init.22()
#7 5.277        github.com/go-critic/go-critic@v0.6.2/checkers/embedded_rules.go:46 +0x488
------
executor failed running [/bin/sh -c golangci-lint version]: exit code: 2

With this Dockerfile:

FROM golang:1.17.9
# golangci-lint
# See https://github.com/golangci/golangci-lint/issues/2374
# Use 1.44.2 which works on arm while 1.45.2 doesn't... somehow
RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.45.2
RUN golangci-lint version

[ldez]

Could you try with the binary of go-critic?