Update support for function matching in Ruleguard

[timkral]

Your feature request related to a problem? Please describe.

I'm trying to write the following rule via Ruleguard in the go-critic linter:

m.Match("func ($_ $_) $methodName($*args) $*_ { $*_; }").Where(m["methodName"].Text.Matches("^test"))

I've tested this rule natively with the latest version of the ruleguard client and it works as expected. However, when using it with the latest version of golangci-lint, the rule does not work.

Describe the solution you'd like.

I believe this just requires an upgrade of the go-critic dependency within golangci-lint.

Ruleguard updated it function matching logic in v0.3.5 - quasilyte/go-ruleguard#225

The latest version of go-critic, v0.5.7, uses Ruleguard v0.3.7 which includes the above fix.

As of this writing, golangci-lint uses go-critic v0.5.6.

Describe alternatives you've considered.

None.

Additional context.

No response

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

Related to #2041

[quasilyte]

#2041 should be fixed by go-critic/go-critic#1072
We'll do a new go-critic release in a few days, so we can include some more changes into the train.

[timkral]

Awesome, thanks for the update @quasilyte !

[sebastien-rosset]

PR #2041 was merged into golangci-lint master, it has has go-critic 0.6.1 (from 0.5.6) and ruleguard 0.3.13 (from 0.3.4)

[timkral]

@sebastien-rosset Thank you for the update. Are there plans to release a new version of golangci-lint anytime soon?

[sebastien-rosset]

Looking at the release history, there is a release roughly once a month.