Skip to content

Multi-line output of gochecknoglobals description in golangci-lint linters is confusing in non-color environments #1594

Closed
@bconway

Description

@bconway

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Please include the following information:

Version of golangci-lint
$ golangci-lint --version
golangci-lint has version v1.34.1 built from (unknown, mod sum: "h1:xf1yVlLBNeCIoOHWXhwqnUeaqzONllRSgiLSahNt0Mw=") on (unknown)
Config file
$ cat .golangci.yml
cat: .golangci.yml: No such file or directory
Go environment
$ go version
go version go1.15.6 darwin/amd64

This is not a new issue, but I keep forgetting to report it. Of all the linters in golangci-lint linters, gochecknoglobals is the only one that has a multi-line output, and it also includes multiple blank newlines. In non-colorized output, based on terminal or piping to less without colorization, this is confusing and looks like a new section:

Screen Shot 2020-12-29 at 9 02 48 AM

Perhaps cutting the description down to a single sentence to match the other linters would make things more uniform?

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions