Skip to content

forbidigo uses makezero in the lint reports #1589

Closed
@SVilgelm

Description

@SVilgelm

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

I enabled forbidigo and got these errors:

internal/i18n/main.go:15:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(i18n.GenerateJSON()))
        ^
pkg/cmd/gen/i18n/i18n.go:17:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(i18n.GenerateJSON()))
        ^
pkg/cmd/gen/config/config.go:55:2: use of `fmt.Println` forbidden by pattern `^fmt\.Print(|f|ln)$` (makezero)
        fmt.Println(string(data))
        ^

As you can see It uses makezero in the report

Issue was introduced in here: https://github.com/golangci/golangci-lint/pull/1569/files#diff-f0557183cd3a50b72b0c7c3477c73b79c2e8bdd805652fe7c234cc23bf661b95R49

the forbidigoName should be used instead of makezeroName

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions