-
Notifications
You must be signed in to change notification settings - Fork 2.3k
go/analysis/internal/checker: make applyFixes work from the first character #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 2ea2ad1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
Message from Tim King: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Abirdcfly Abirdcfly: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
This PR (HEAD: 30652ec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
Message from Tim King: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Tim King: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
This PR (HEAD: fff0702) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: c378c73) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
Message from Abirdcfly Abirdcfly: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Tim King: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
This PR (HEAD: 038e631) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
Message from Tim King: Patch Set 6: Run-TryBot+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Tim King: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Gopher Robot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from kokoro: Patch Set 7: Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Abirdcfly Abirdcfly: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from kokoro: Patch Set 7: gopls-CI+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Gopher Robot: Patch Set 7: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
Message from Tim King: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
…racter Make sure modifying the first character of the file takes effect. Fixes golang/go#54774
Message from Benny Siegert: Patch Set 7: Code-Review+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
This PR (HEAD: b58bbdf) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it. Tip: You can toggle comments from me using the |
Message from Abirdcfly Abirdcfly: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/426654. |
…racter Make sure modifying the first character of the file takes effect. Fixes golang/go#54774 Change-Id: Ib77231b9bd15f35fe50b2c2d6c7ea260c9c3cba5 GitHub-Last-Rev: b58bbdf GitHub-Pull-Request: #393 Reviewed-on: https://go-review.googlesource.com/c/tools/+/426654 Reviewed-by: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Tim King <taking@google.com>
This PR is being closed because golang.org/cl/426654 has been merged. |
Make sure modifying the first character of the file takes effect.
Fixes golang/go#54774