Skip to content

go/analysis/internal/checker: make applyFixes work from the first character #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Aug 30, 2022

Make sure modifying the first character of the file takes effect.

Fixes golang/go#54774

@gopherbot
Copy link
Contributor

This PR (HEAD: 2ea2ad1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 30652ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: fff0702) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@Abirdcfly Abirdcfly changed the title go/analysis/internal/checker: applyFixes condition changed to greater… go/analysis/internal/checker: applyFixes the first character to work Sep 4, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: c378c73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 5:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 038e631) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 6: Run-TryBot+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/40b73334-c1db-4c18-aee6-65c32576f00e


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 7: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/40b73334-c1db-4c18-aee6-65c32576f00e


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 7: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@Abirdcfly Abirdcfly changed the title go/analysis/internal/checker: applyFixes the first character to work go/analysis/internal/checker: make applyFixes work from the first character Sep 7, 2022
…racter

Make sure modifying the first character of the file takes effect.

Fixes golang/go#54774
@gopherbot
Copy link
Contributor

Message from Benny Siegert:

Patch Set 7: Code-Review+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b58bbdf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/426654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Abirdcfly Abirdcfly:

Patch Set 8:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/426654.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 7, 2022
…racter

Make sure modifying the first character of the file takes effect.

Fixes golang/go#54774

Change-Id: Ib77231b9bd15f35fe50b2c2d6c7ea260c9c3cba5
GitHub-Last-Rev: b58bbdf
GitHub-Pull-Request: #393
Reviewed-on: https://go-review.googlesource.com/c/tools/+/426654
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Tim King <taking@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/426654 has been merged.

@gopherbot gopherbot closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/tools/go/analysis/internal/checker: if offsetedit's start is 0, it can't be apply
2 participants