Skip to content

x/tools/internal/gcimporter: update iexport.go to support generics #48392

Closed
@findleyr

Description

@findleyr

CL 349949 updates x/tools/internal/gcimporter/iimport.go to support generics, by porting over changes from the standard library go/internal/gcimporter package. It will take longer to port iexport.go, as it must be translated from cmd/compile/internal/typecheck/iexport.go. In the meantime (~days, I expect), I think we should skip x/tools/go/internal/gcimporter.TestIExportData_stdlib on Go 1.18, in order to avoid failures on the x/tools Trybots on Go repo CLs that use generics.

This issue tracks that process (skipping the test, updating the exporter, and unskipping).

CC @griesemer @mdempsky @danscales @ianlancetaylor

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.SoonThis needs action soon. (recent regressions, service outages, unusual time-sensitive situations)ToolsThis label describes issues relating to any tools in the x/tools repository.release-blocker

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions