Skip to content

Commit 4d84fb8

Browse files
committed
Deadlock in test if a TLS error occurs
A Go routine was, on an error, returning without sending a message on its signaling channel, so the main program was blocking forever waiting for a message that was never sent. Found while breaking crypto/tls.
1 parent 7846e25 commit 4d84fb8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/crypto/tls/handshake_server_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ func TestRenegotiationExtension(t *testing.T) {
200200
n, err := c.Read(buf)
201201
if err != nil {
202202
t.Errorf("Server read returned error: %s", err)
203-
return
204203
}
205204
c.Close()
206205
bufChan <- buf[:n]

0 commit comments

Comments
 (0)