Skip to content

Commit 7846e25

Browse files
author
eric fang
committed
cmd/link: fix TestLargeText
Do not need to add single quotes '' when passing the parameter value of the -ldflags option, otherwise the following error will be reported: invalid value "'-linkmode=external'" for flag -ldflags: parameter may not start with quote character. Change-Id: I322fa7079ac24c8a68d9cb0872b0a20dbc4893d1 Reviewed-on: https://go-review.googlesource.com/c/go/+/410074 Reviewed-by: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Run-TryBot: Eric Fang <eric.fang@arm.com>
1 parent 74dc84a commit 7846e25

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd/link/linkbig_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func TestLargeText(t *testing.T) {
9797
}
9898

9999
// Build and run with external linking
100-
cmd = exec.Command(testenv.GoToolPath(t), "build", "-o", "bigtext", "-ldflags", "'-linkmode=external'")
100+
cmd = exec.Command(testenv.GoToolPath(t), "build", "-o", "bigtext", "-ldflags", "-linkmode=external")
101101
cmd.Dir = tmpdir
102102
out, err = cmd.CombinedOutput()
103103
if err != nil {

0 commit comments

Comments
 (0)