Skip to content

crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr #71

wants to merge 1 commit into from

Conversation

jaytaylor
Copy link
Contributor

@jaytaylor jaytaylor commented Jan 8, 2019 •
edited by bradfitz
Loading

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@jaytaylor jaytaylor force-pushed the knownhosts-checkAddr-doc branch from ef200b4 to ce92f04 Compare January 8, 2019 19:56
leonklingele
leonklingele reviewed Jan 8, 2019
View reviewed changes
@jaytaylor jaytaylor force-pushed the knownhosts-checkAddr-doc branch from ce92f04 to 9b42ada Compare January 8, 2019 20:45
@jaytaylor jaytaylor force-pushed the knownhosts-checkAddr-doc branch from 9b42ada to fd7b92d Compare January 8, 2019 20:47
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 8, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: fd7b92d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/156878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/156878.
After addressing review feedback, remember to publish your drafts!

@bradfitz bradfitz changed the title crypto/ssh/knownhosts: Corrected out-of-date documentation for checkAddr crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr Jan 8, 2019
@gopherbot
Copy link
Contributor

Message from Han-Wen Nienhuys:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/156878.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bc4ad573

Please don’t reply on this GitHub thread. Visit golang.org/cl/156878.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/156878.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 23, 2019
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
057139c 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d
GitHub-Pull-Request: #71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/156878 has been merged.

@gopherbot gopherbot closed this Jan 23, 2019
Alkorin pushed a commit to Alkorin/crypto that referenced this pull request Jan 23, 2019
@zapu
Fix out-of-bands access panics in curve_impl.go (golang#71)
c84d7cb 
Fix out-of-bands access panics in curve_impl.go file. Curve interface
functions expected 32-byte big.Ints and panicked with buffers of
different length. Because these functions are not expected to return
errors, they were fixed by adding trunaction if passed arguments are
bigger, and 0-filling if arguments are smaller. Same thing for
MarshalType40 - if passed coordinate is of unexpected size,
truncation might happen, returning bad data.

Added a test trying to decrypt PGP message bundle with invalid cv25519
coordinate.
bored-engineer pushed a commit to bored-engineer/ssh that referenced this pull request Oct 13, 2019
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
024b5f3 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
bored-engineer pushed a commit to bored-engineer/ssh that referenced this pull request Oct 13, 2019
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
b1d40a6 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
bored-engineer pushed a commit to bored-engineer/ssh that referenced this pull request Oct 13, 2019
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
ac98bf4 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
jandd pushed a commit to jandd/crypto that referenced this pull request Jun 26, 2021
@larabr
openpgp: Remove quick check in Symmetrically Encrypted packet decrypt…
1ce7a43 
…ion (golang#71)

Remove quick check that detects key correctness after partial data decryption,
as the check is known to expose a decryption oracle:
https://eprint.iacr.org/2005/033.pdf.
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 28, 2022
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
5f2f15e 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
0a4f178 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
00c094d 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this pull request Feb 16, 2023
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
2431b8f 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this pull request Sep 15, 2023
@jaytaylor @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
564f36e 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d
GitHub-Pull-Request: golang#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this pull request Jul 1, 2024
@desdeel2d0m @hanwen
crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr
9ed5879 
Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
GitHub-Last-Rev: fd7b92d97c7b52ae00821bad099cf45ff9836cd1
GitHub-Pull-Request: golang/crypto#71
Reviewed-on: https://go-review.googlesource.com/c/156878
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonklingele leonklingele leonklingele left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaytaylor @googlebot @gopherbot @leonklingele