Use hostname from DSN as default for TLS if tls=true #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
methane
approved these changes
Apr 3, 2017
julienschmidt
approved these changes
Apr 28, 2017
5 tasks
chrisfarms
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Sep 7, 2017
The healthcheck app was updated to use a more recent Go version and the latest compatible depenencies. The newer Go standard library is stricter about ensuring that the ServerName field is correctly set for TLS. The current version of the mysql library does not set the required `ServerName` when using a connection string with 'tls=true'. A fix has been already been merged and will be released in the next version (v1.4) of the go-sql-driver/mysql lib. See go-sql-driver/mysql#564 To workaround the problem in the meantime, we register a "custom" TLS config which correctly sets the ServerName.
chrisfarms
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Sep 7, 2017
The healthcheck app was updated to use a more recent Go version and the latest compatible depenencies. The newer Go standard library is stricter about ensuring that the ServerName field is correctly set for TLS. The current version of the mysql library does not set the required `ServerName` when using a connection string with 'tls=true'. A fix has been already been merged and will be released in the next version (v1.4) of the go-sql-driver/mysql lib. See go-sql-driver/mysql#564 To workaround the problem in the meantime, we register a "custom" TLS config which correctly sets the ServerName.
chrisfarms
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Sep 7, 2017
The healthcheck app was updated to use a more recent Go version and the latest compatible depenencies. The newer Go standard library is stricter about ensuring that the ServerName field is correctly set for TLS. The current version of the mysql library does not set the required `ServerName` when using a connection string with 'tls=true'. A fix has been already been merged and will be released in the next version (v1.4) of the go-sql-driver/mysql lib. See go-sql-driver/mysql#564 To workaround the problem in the meantime, we register a "custom" TLS config which correctly sets the ServerName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is some code to set the
ServerNamein the tlsConfig to the hostname from the DSN, but thisseems to be only used if
tlsis set to something other than true/false/skip-verify.I think this should also be used if
tlsis set to true.I don't think
tls=truereally works at all with the current code. The current code does work with custom/false/skip-verify. This surprises me and leads me to wonder my understanding oftls=trueis correct.Checklist
don't think any change is needed
I'm already listed