README: document DSN system var quoting rules (#405) #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Examples: | ||
| * `autocommit=1`: `SET autocommit=0` | ||
| * [`time_zone=%27Europe%2FParis%27`](https://dev.mysql.com/doc/refman/5.5/en/time-zone-support.html): `SET time_zone='Europe/Paris'` | ||
| * [`tx_isolation=%27REPEATABLE-READ%27`](https://dev.mysql.com/doc/refman/5.5/en/server-system-variables.html#sysvar_tx_isolation): `SET tx_isolation=REPEATABLE-READ` |
There was a problem hiding this comment.
This line is not clear. Why are there quotes (%27) in the DSN example, but not in the "translated" system var?
There was a problem hiding this comment.
Good catch. I'll fix that.
|
Fixed (following @julienschmidt review) and rebased. |
| (which implies values of string variables must be wrapped with `%27`) | ||
|
|
||
| Examples: | ||
| * `autocommit=1`: `SET autocommit=0` |
There was a problem hiding this comment.
something is wrong here too
Improve documentation of quoting rules for system var values in DSN. go-sql-driver#405
|
Fixed (following @julienschmidt second review) and rebased. |
julienschmidt
approved these changes
Nov 5, 2016
|
Thanks, the changes look fine to me now. |
|
Added myself to AUTHORS as requested. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation fix for #405: improve documentation of quoting rules for system var values in DSN.
Fixes #405