Skip to content

Expanded README around difference between loc and time_zone params #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2015

Conversation

soroushjp
Copy link
Contributor

Adding a little clarification around loc's purpose since it is a Go-specific param that may be confused with the MySQL time_zone setting. Great that both params are available.

@julienschmidt
Copy link
Member

Please also add yourself to the list in the AUTHORS file

@soroushjp soroushjp force-pushed the sjp-readme-timezone branch from 5af5b3e to e6cb533 Compare May 2, 2015 00:48
@soroushjp
Copy link
Contributor Author

Added :)

@julienschmidt
Copy link
Member

LGTM

Thanks!

julienschmidt added a commit that referenced this pull request May 2, 2015
Expanded README around difference between loc and time_zone params
@julienschmidt julienschmidt merged commit 57af768 into go-sql-driver:master May 2, 2015
@julienschmidt julienschmidt added this to the v1.3 milestone May 2, 2015
@soroushjp soroushjp deleted the sjp-readme-timezone branch May 2, 2015 01:50
@soroushjp
Copy link
Contributor Author

Thanks for a great library, using it in a project now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants