tls.Config: strict key check + remove data race #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also resorted code
ghost
assigned 
| @@ -253,6 +213,78 @@ func scramblePassword(scramble, password []byte) []byte { | |||
| return scramble | |||
| } | |||
|
|
|||
| // Returns the bool value of the input. | |||
| // The 2nd return type indicates if the input was a valid bool value | |||
| func readBool(input string) (value bool, valid bool) { | |||
There was a problem hiding this comment.
bool, error instead of bool, bool as return value to get rid of some duplication?
There was a problem hiding this comment.
no, then we'd have to compare with the err in some cases which I'd like to avoid.
| // Returns the bool value of the input. | ||
| // The 2nd return value indicates if the input was a valid bool value | ||
| func readBool(input string) (value bool, valid bool) { | ||
| switch input { |
There was a problem hiding this comment.
switch strings.ToLower(input)...?
There was a problem hiding this comment.
I don't think that this is necessary. I wouldn't consider "trUE" etc. as a valid bool formatting, neither does Go's stdlib. Also the current way is more efficient.
|
LGTM though I'd love to have my latest comment addressed (convert if-chain to switch) |
julienschmidt
added a commit
that referenced
this pull request
Jul 1, 2013
tls.Config: strict key check + remove data race
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.