Improved LOAD INFILE documentation #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| // ... | ||
| // | ||
| func RegisterLocalFile(filePath string) { | ||
| if fileRegister == nil { |
There was a problem hiding this comment.
this should probably be protected by sync.Once instead of the nil check. Otherwise, it's a very improbable race condition if someone blatantly misuses the driver...
There was a problem hiding this comment.
Right. I think sticking with the original concept of initializing this once at start up is the better option. The tls.Confing thing must also be changed.
|
PTAL; removed the lazy init commit. I'll change the TLS stuff in another PR (and some other related stuff) |
| // mysql.RegisterReaderHandler("data", func() io.Reader { | ||
| // var csvReader io.Reader // Some Reader that returns CSV data | ||
| // ... // Open Reader here | ||
| // return csvReader |
|
LGTM when Travis is green (in a minute or so) |
julienschmidt
added a commit
that referenced
this pull request
Jul 1, 2013
Improved LOAD INFILE documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.