Fixed "print function's "end" option error in CPython" #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code writes different string to the stream than in CPython: print(1,2,3, end="||\n") The following code writes different string to the stream than in CPython: print(1,2,3, end="||\n") I fixed that bug by modifying the code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 69.09% 69.10% +0.01%
==========================================
Files 60 60
Lines 10674 10678 +4
==========================================
+ Hits 7375 7379 +4
Misses 2781 2781
Partials 518 518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sungmin-Joo
changed the title
corona10
requested changes
Sep 27, 2019
add "end" test in cpython
|
@corona10 |
|
@Sungmin-Joo AS-IS>>> print(1,2,3, end="||\n")
1||
2||
3||TO-BE>>> print(1,2,3, end="||\n")
1 2 3|| |
sbinet
reviewed
Sep 27, 2019
| @@ -186,6 +186,12 @@ func builtin_print(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Obje | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if kwargs["sep"] != nil { | |||
There was a problem hiding this comment.
what about:
switch sep, ok := kwargs["sep"]; ok {
case true:
sepObj = sep
default:
sepObj = py.String(" ")
}| print("hello","gpython", end="123\n") | ||
| except TypeError as e: | ||
| ok = True | ||
| assert ok, "TypeError not raised" |
There was a problem hiding this comment.
Suggested change
| assert ok, "TypeError not raised" | |
| assert ok, "TypeError not raised when 'sep' is not in the kwargs dict" |
that said, I am not sure I understand this test.
do we really want this line to raise an exception? why?
| @@ -281,6 +281,12 @@ def gen2(): | |||
| ok = True | |||
| assert ok, "TypeError not raised" | |||
|
|
|||
| try: | |||
| print("hello","gpython", end="123\n") | |||
There was a problem hiding this comment.
Suggested change
| print("hello","gpython", end="123\n") | |
| print("hello", "gpython", end="123\n") |
|
@Sungmin-Joo @sbinet err := py.ParseTupleAndKeywords(nil, kwargs, "|ssOO:print", kwlist, &sepObj, &endObj, &file, &flush)I am now closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code writes different string to the stream than in CPython:
I fixed that bug by modifying the code
resolved: #93