print should use __str__ or __repr__ when available

[raff]

see #24

[codecov-io]

Codecov Report

Merging #26 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   64.59%   64.56%   -0.04%     
==========================================
  Files          55       55              
  Lines        9997    10002       +5     
==========================================
  Hits         6458     6458              
- Misses       3079     3084       +5     
  Partials      460      460

Impacted Files	Coverage Δ
builtin/builtin.go	74.45% <0%> (-0.92%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7b5ec...afa0c4f. Read the comment docs.

[ncw]

See inline for notes.

Can you do some tests (in python) in builtin/tests/builtin.py too please?

A useful fix - thank you :-)

[ncw]

This isn't quite right - this needs to call py.Str which will fall back to py.Repr

If you only look for the M__str__ then you'll miss the user defined methods.

[raff]

This works with this test:

class X(object):
  def __init__(self, x):
    self.x = x
  def __str__(self):
    return "my name is %s" % self.x

class Y(object):
  def __init__(self, x):
    self.x = x

  def __repr__(self):
    return "my nome is %s" % self.x

print(X(42))
print(Y('hello'))

Note that I cannot add any test to builtin/tests/builtin.py because there is no way to check the result of print (until support for redirects is implemented)

[raff]

re-implemented with py.Str

[raff]

I have updated with py.Str

Can't really add any test builtin/tests/builtin.py right now, since there is no way to test the result of "print" (but I have some work in progress to support print to file)

[ncw]

I see what you mean about the tests. I'll merge this as it is a definite improvement thanks :-)

Some tests would be nice at some point!

[corona10]

@ncw In the future, we can add the test which capturing sys.stdout. But not this time :)