Fix minor regressions in legacy error strings #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
force-pushed
the
legacy-error-strings
branch
2 times, most recently
from
867ce90 to
5346743
Compare
mvdan
approved these changes
Jan 14, 2025
I only kept changes in v2 that were objectively an improvement. All the gross stuff was shoved into v1. |
neild
approved these changes
Jan 14, 2025
dsnet
force-pushed
the
legacy-error-strings
branch
from
5346743 to
d3b4f71
Compare
The Go 1 compatability document does not guarantee that error strings remain unchanged across Go releases. However, there is a practical benefit to reducing the churn even if this is not a guaranteed property. Adjust the formatting of v1 error strings to better match how they were historically rendered. This does not ensure 100% equivalency with legacy error strings, but does a better job at mostly preserving the exact string. In the jsontext and jsonwire packages, we make changes to assist in the construction legacy error values. We also make syntactic errors returned by the Decoder more consistent regardless of whether they were produced by a ReadValue or ReadToken call. All changes made to jsontext and jsonwire are an improvement, so we are not taking on technical debt in those packages to support legacy error strings. All legacy transformations are kept in the v1 code.
dsnet
force-pushed
the
legacy-error-strings
branch
from
d3b4f71 to
39d5674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go 1 compatability document does not guarantee that error strings remain unchanged across Go releases. However, there is a practical benefit of reducing the churn even if this is not a guaranteed property.
Adjust the formatting of v1 error strings to better match how they were historically rendered. This does not ensure 100% equivalency with legacy error strings, but
does a better job at mostly preserving the exact string.
In the jsontext and jsonwire packages, we make changes to assist in the construction legacy error values. We also make syntactic errors returned by the Decoder more consistent regardless of whether they were produced by a ReadValue or ReadToken call.