Skip to content

Fix some required SimpleMDE #9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Conversation

jolheiser
Copy link
Member

Fixes #9396
Fixes #9397

The extra RequireTribute cleared up another console error on file upload page.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #9400 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9400      +/-   ##
==========================================
- Coverage   41.51%   41.49%   -0.02%     
==========================================
  Files         569      569              
  Lines       74308    74311       +3     
==========================================
- Hits        30846    30837       -9     
- Misses      39621    39636      +15     
+ Partials     3841     3838       -3
Impacted Files Coverage Δ
routers/repo/pull.go 28.8% <0%> (-0.04%) ⬇️
routers/repo/editor.go 26.61% <0%> (-0.1%) ⬇️
modules/indexer/code/indexer.go 44.73% <0%> (-10.53%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo_list.go 73.14% <0%> (-0.93%) ⬇️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590d56d...5281d67. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2019
@techknowlogick techknowlogick added this to the 1.11.0 milestone Dec 18, 2019
@techknowlogick techknowlogick merged commit ba8f93a into go-gitea:master Dec 18, 2019
@jolheiser jolheiser deleted the simplemde branch December 18, 2019 15:12
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request code review ui broken Web editor upload file to create a new branch and send a pull request failed
6 participants