Skip to content

[backport #7258] add .fa margin like .octicon #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

[backport #7258] add .fa margin like .octicon #7267

merged 1 commit into from
Jun 20, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 20, 2019 •
edited
Loading

Backport of #7258

My local config seems to not generate the same css.
I try to clean it but it still have some browser specific css that wasn't there before.
I will retrieve the content genretate from CI and duplicate (that why the WIP).

@sapk sapk force-pushed the backport-7258 branch 5 times, most recently from b35d9f5 to 8fa4e2b Compare June 20, 2019 12:21
@sapk
Copy link
Member Author

sapk commented Jun 20, 2019 •
edited
Loading

I can't seem to be able to build the correct css and CI doesn't output the full diff. If someone can rebuild it and push it that would be perfect. I will also try to do it on another computer later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2019
@sapk sapk force-pushed the backport-7258 branch 2 times, most recently from 53d8bb1 to 5d629a8 Compare June 20, 2019 13:08
@sapk sapk changed the title [wip] [backport 7258] add .fa margin like .octicon [backport #7258] add .fa margin like .octicon Jun 20, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2019
@lunny lunny merged commit e94a842 into go-gitea:release/v1.8 Jun 20, 2019
@techknowlogick techknowlogick added this to the 1.8.4 milestone Jun 20, 2019
@sapk sapk deleted the backport-7258 branch June 20, 2019 15:43
@davidsvantesson davidsvantesson mentioned this pull request Aug 5, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.8.4
Development

Successfully merging this pull request may close these issues.
5 participants
@sapk @lunny @adelowo @techknowlogick @GiteaBot