Skip to content

Remove util.RemoveAll as no longer needed #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

zeripath
Copy link
Contributor

util.RemoveAll was a workaround pre-go1.7 which is no longer needed and should have been removed.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 10, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e836b88). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6299   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      358           
  Lines             ?    51016           
  Branches          ?        0           
=========================================
  Hits              ?    19826           
  Misses            ?    28321           
  Partials          ?     2869
Impacted Files Coverage Δ
models/admin.go 81.63% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e836b88...1da6d97. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2019
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 10, 2019
@lafriks lafriks merged commit dbab98c into go-gitea:master Mar 10, 2019
@zeripath zeripath deleted the remove-utils-removeall branch March 13, 2019 09:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants