Skip to content

feat: testing in go 1.10 version. #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 7, 2018
Merged

feat: testing in go 1.10 version. #3899

merged 9 commits into from
May 7, 2018

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented May 5, 2018

Testing with 1.10 version using Golang official image.

@thehowl
Copy link
Contributor

thehowl commented May 5, 2018

Why were we using the webhippie image in the first place? cc/ @tboerger - does it have any advantages over the standard golang image?

Integration tests seem to fail because we don't have git lfs - might need to install it on the image

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2018
@appleboy
Copy link
Member Author

appleboy commented May 5, 2018

@thehowl I already add git-lfs package. Waiting drone buid.

@appleboy
Copy link
Member Author

appleboy commented May 5, 2018

@thehowl

Why were we using the webhippie image in the first place? cc/ @tboerger - does it have any advantages over the standard golang image?

So we move to the standard golang image now because of webhippie is not the latest golang image.

@tboerger
Copy link
Member

tboerger commented May 5, 2018

I can add the latest version... The official go image doesn't include make ;)

@codecov-io
Copy link

codecov-io commented May 5, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@eec2179). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3899   +/-   ##
=========================================
  Coverage          ?   20.17%           
=========================================
  Files             ?      145           
  Lines             ?    29171           
  Branches          ?        0           
=========================================
  Hits              ?     5884           
  Misses            ?    22393           
  Partials          ?      894

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec2179...365c374. Read the comment docs.

@appleboy
Copy link
Member Author

appleboy commented May 5, 2018

@tboerger official image support make command. See:

https://github.com/docker-library/golang/blob/329b6672949337c4469351b2e8b8575459a75c7f/1.10/stretch/Dockerfile#L8

just missing git-lfs package which already fixes in this PR.

@appleboy appleboy added this to the 1.5.0 milestone May 6, 2018
@appleboy appleboy added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 6, 2018
@lunny
Copy link
Member

lunny commented May 6, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 6, 2018
@tboerger
Copy link
Member

tboerger commented May 6, 2018

Debian based... ewww... Have fun with that, I will continue with alpine :)

@appleboy appleboy requested a review from lafriks May 7, 2018 01:38
lafriks
lafriks requested changes May 7, 2018
View reviewed changes
.drone.yml Outdated
@@ -56,21 +56,18 @@ pipeline:
event: [ push, tag, pull_request ]

build-without-gcc:
image: webhippie/golang:1.8
image: golang:1.10
pull: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be left as golang:1.8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e054e92 Done!

appleboy added 8 commits May 7, 2018 13:10
@appleboy
feat: testing in go 1.10 version.
c60bc9b
@appleboy
add git-lfs command
261d11f 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
add git-lfs command
14679e3 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
revert
e3de628 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update image
febb4bf 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update command
cd6d676 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update command
54476d9 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
update build wihtout gcc version
e054e92 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2018
@appleboy appleboy merged commit 0b718e0 into go-gitea:master May 7, 2018
@appleboy appleboy deleted the golang branch May 7, 2018 14:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@appleboy @thehowl @tboerger @codecov-io @lunny @lafriks @bkcsoft