Always build, even when it's up-to-date #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
added
topic/deployment
type/enhancement
bkcsoft
force-pushed
the
bkcsoft/always-build
branch
from
31db75a to
afad46f
Compare
bkcsoft
force-pushed
the
bkcsoft/always-build
branch
from
afad46f to
63fb812
Compare
|
I'm OK with that, but for sure guys like strk votes against it :) LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
LGTM as I trust "go" to do the right thing about dependencies. |
|
@strk I'm not entirely sure, maybe wildcard only picks what in the current pwd and not recursing down into folders? |
|
@strk Called it! 😆
https://www.gnu.org/software/make/manual/html_node/Wildcard-Function.html |
|
Bingo, than it's @tboerger fault :P
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
make buildwas to be preceded withmake cleanotherwise it won't build. This is because of how make works internally so AFAIK nothing can be done about that 😒This PR "fixes" it by ignoring the fact that it's built and always builds