Skip to content

Split GetLatestCommitStatus as two functions #34535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

Split GetLatestCommitStatus as two functions #34535

merged 3 commits into from
May 26, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented May 25, 2025

Extract from #34531. This will reduce unnecessary count operation in databases.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 25, 2025
@lunny lunny added this to the 1.25.0 milestone May 25, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 25, 2025
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 25, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 26, 2025
wxiaoguang
wxiaoguang reviewed May 26, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed May 26, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed May 26, 2025
View reviewed changes
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 26, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 26, 2025
@lunny lunny enabled auto-merge (squash) May 26, 2025 18:35
@lunny lunny merged commit 688da55 into go-gitea:main May 26, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 26, 2025
@lunny lunny deleted the lunny/split_get_last_commit_statuses branch May 26, 2025 19:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 27, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1794de8 
* giteaofficial/main:
  Split GetLatestCommitStatus as two functions (go-gitea#34535)
  Don't display error log when .git-blame-ignore-revs doesn't exist (go-gitea#34457)
  Add sort option recentclose for issues and pulls (go-gitea#34525)
  fix: return 201 Created for CreateVariable API responses (go-gitea#34517)
  Actions list (go-gitea#34530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@delvh delvh delvh approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @wxiaoguang @delvh @hiifong @GiteaBot