agit flow add refs/for-review/<pull index> support #31245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a1012112796 <1012112796@qq.com>
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
Can you give some official documentation links for this new refs? |
|
lunny
reviewed
Sep 24, 2024
services/agit/agit.go
Outdated
| @@ -36,6 +36,75 @@ func ProcReceive(ctx context.Context, repo *repo_model.Repository, gitRepo *git. | |||
| return nil, fmt.Errorf("failed to get user. Error: %w", err) | |||
| } | |||
|
|
|||
| updateExistPull := func(pr *issues_model.PullRequest, i int) error { | |||
There was a problem hiding this comment.
How about using a normal function?
Signed-off-by: a1012112796 <1012112796@qq.com>
|
if author not enabled |
hiifong
reviewed
Dec 26, 2024
| @@ -238,7 +238,8 @@ func runServ(c *cli.Context) error { | |||
| if git.DefaultFeatures().SupportProcReceive { | |||
| // for AGit Flow | |||
| if cmd == "ssh_info" { | |||
| fmt.Print(`{"type":"gitea","version":1}`) | |||
| data := private.GetSSHInfo(ctx) | |||
| fmt.Print(data) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Print(data) | |
| fmt.Println(data) |
There was a problem hiding this comment.
Actually, it should use c *cli.Context stdout, to make it testable.
hiifong
reviewed
Dec 26, 2024
| @@ -104,6 +105,12 @@ func (ref RefName) IsFor() bool { | |||
| return strings.HasPrefix(string(ref), ForPrefix) | |||
| } | |||
|
|
|||
| var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `[1-9][0-9]*`) | |||
There was a problem hiding this comment.
Maybe you need to ensure that the pull index is an integer greater than 0. ^[1-9]\d*$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, follow #14295
it can be used by author to update pull by pull index
and also can be used by mainter if the
Allow edits by maintainersoption was enabled.Documentation ref: https://git-repo.info/en/2020/03/agit-flow-git-repo/