Fix git lfs path

[sapk]

After re-testing #2938 and relooking at specs.

Found two errors from me :

• Specs indicate : https://github.com/git-lfs/git-lfs/blob/master/docs/api/locking.md

All File Locking requests require the following HTTP headers:
Accept: application/vnd.git-lfs+json
Content-Type: application/vnd.git-lfs+json

But git client (at least git version 2.15.0) doesn't send Content-Type: application/vnd.git-lfs+json for GET methods. -> so remove check for it.

• Path for LFS is :reponame.git not :reponame.
  This is also use for batch path https://github.com/git-lfs/git-lfs/blob/master/docs/api/batch.md

[lafriks]

LGTM

[codecov-io]

Codecov Report

Merging #3016 into master will increase coverage by <.01%.
The diff coverage is 29.62%.

@@            Coverage Diff             @@
##           master    #3016      +/-   ##
==========================================
+ Coverage   33.01%   33.01%   +<.01%     
==========================================
  Files         269      270       +1     
  Lines       39492    39512      +20     
==========================================
+ Hits        13039    13046       +7     
- Misses      24603    24617      +14     
+ Partials     1850     1849       -1

Impacted Files	Coverage Δ
models/migrations/migrations.go	2.9% <ø> (ø)	⬆️
models/migrations/v49.go	0% <0%> (ø)
routers/routes/routes.go	86.99% <100%> (ø)	⬆️
modules/lfs/locks.go	47.39% <63.63%> (-0.2%)	⬇️
modules/indexer/indexer.go	70% <0%> (-7.5%)	⬇️
modules/process/manager.go	76.81% <0%> (-4.35%)	⬇️
models/repo.go	38% <0%> (+0.18%)	⬆️
models/repo_indexer.go	49.5% <0%> (+3.96%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80d147...264d496. Read the comment docs.

[Bwko]

LGTM

[lafriks]

@sapk you are also missing migration step to add new lock table that could cause problems later if upgrading from <1.3 to something newer where is migration step that changes lock table

[sapk]

@lafriks Shouldn't https://github.com/go-gitea/gitea/blob/master/models/models.go#L120 will automatically create the table if not exist ?

[lafriks]

@sapk yes it will but if you add migration that touches or uses table that still does not exists (like upgrading from version where such table did not exist) that migration will fail as tables are sync2'ed (created) after migrations has run

[lafriks]

@sapk you are not calling this function from migrations.go

[sapk]

@lafriks I better understand. I remember now also problems when the struct was updated and depending of version installed previously users suffer random bug. Good catch and done.

[sapk]

I need sleep ^^. Should be good.
Sorry for the mistakes.