Skip to content

Allow watching custom events #26865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Sep 1, 2023

Implements #21948

At the moment you can only watch all events if you watch a repo. With this PR you can now choose which event you want to watch. You can choose between Issues, Pull Requests and Releases. It's basically the same as GitHub does.

At the Moment there is no UI to configure this. It can only be configured through the API. But the Backend is fully working and ready to review.

To-Do:

  • Frontend
  • Tests
  • Migration

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2023
@JakobDev JakobDev marked this pull request as draft September 1, 2023 12:59
@JakobDev
Copy link
Contributor Author

JakobDev commented Sep 4, 2023

I have now added a Frontend. I tried to mimic the one of GitHub. It is currently really basic and looks ugly, but it works. Its is more a prof of concept than a final UI. If you click on "Custom" on GitHub, it will also open a new page where you can choose what you want to watch, but I don't know if this is possible with the Gitea UiI

grafik

@silverwind You have a loot more frontend skills. Maybe you could take a look at it?

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 4, 2023
@CaiCandong
Copy link
Member

This change affects the subscriptions endpoint. I am waiting for the PR, then to adjust the #26797

@puni9869
Copy link
Member

puni9869 commented Sep 5, 2023

Which one will go first this pr or #26797 <-- this one.

@CaiCandong
Copy link
Member

CaiCandong commented Sep 5, 2023

Which one will go first this pr or #26797 <-- this one.

#26865 first, then I should do some adjusting in #26797. @JakobDev What's your opinion?

@JakobDev
Copy link
Contributor Author

JakobDev commented Sep 5, 2023

What's your opinion?

Correct me if I'm wrong, but it looks like your PR is about wtaching Issues, but this PR is about watching Repos, so they don't touch the same codebase.

@CaiCandong
Copy link
Member

Correct me if I'm wrong, but it looks like your PR is about wtaching Issues, but this PR is about watching Repos, so they don't touch the same codebase.

Yes, but the current logic is that watching the repository is the same as subscribing to the entire repository's issue. But I noticed you'll be modifying this logic, so maybe I should wait for you to finish it first.

@JakobDev
Copy link
Contributor Author

JakobDev commented Sep 5, 2023

If you think this also affects your PR, you should wait. This PR is almost finished. The big missing part is a good UI.

@silverwind
Copy link
Member

Can maybe take a look at ui in a few days.

@JakobDev
Copy link
Contributor Author

JakobDev commented Sep 7, 2023

My thanks! I have experimented on my local machine, but I can't get it looking good. I have tried to do a second page for custom options like GitHub, but it's really hacky. The backend and tests are finished. the only missing thing is a god looking frontend.

@puni9869
Copy link
Member

puni9869 commented Sep 7, 2023

I give a try today.

@puni9869
Copy link
Member

@JakobDev I have started working on the UI, currently in the middle. Will share the draft Ui soon.

@puni9869
Copy link
Member

Could you resolved the conflicts and update this branch.

@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Oct 24, 2023
@JakobDev
Copy link
Contributor Author

I have started working on the UI,

Thanks

Could you resolved the conflicts and update this branch.

Done

@BluePixel4k
Copy link

@puni9869 Is there any news about your UI? Thx

@KaKi87
Copy link

KaKi87 commented May 11, 2024

Hi,
How is this going ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants