-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Allow watching custom events #26865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow watching custom events #26865
Conversation
I have now added a Frontend. I tried to mimic the one of GitHub. It is currently really basic and looks ugly, but it works. Its is more a prof of concept than a final UI. If you click on "Custom" on GitHub, it will also open a new page where you can choose what you want to watch, but I don't know if this is possible with the Gitea UiI @silverwind You have a loot more frontend skills. Maybe you could take a look at it? |
This change affects the subscriptions endpoint. I am waiting for the PR, then to adjust the #26797 |
Which one will go first this pr or #26797 <-- this one. |
Correct me if I'm wrong, but it looks like your PR is about wtaching Issues, but this PR is about watching Repos, so they don't touch the same codebase. |
Yes, but the current logic is that watching the repository is the same as subscribing to the entire repository's issue. But I noticed you'll be modifying this logic, so maybe I should wait for you to finish it first. |
If you think this also affects your PR, you should wait. This PR is almost finished. The big missing part is a good UI. |
Can maybe take a look at ui in a few days. |
My thanks! I have experimented on my local machine, but I can't get it looking good. I have tried to do a second page for custom options like GitHub, but it's really hacky. The backend and tests are finished. the only missing thing is a god looking frontend. |
I give a try today. |
@JakobDev I have started working on the UI, currently in the middle. Will share the draft Ui soon. |
Could you resolved the conflicts and update this branch. |
Thanks
Done |
@puni9869 Is there any news about your UI? Thx |
Hi, |
Implements #21948
At the moment you can only watch all events if you watch a repo. With this PR you can now choose which event you want to watch. You can choose between Issues, Pull Requests and Releases. It's basically the same as GitHub does.
At the Moment there is no UI to configure this. It can only be configured through the API. But the Backend is fully working and ready to review.
To-Do: