Skip to content

Move init functions from routers/install to routers/init #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2016

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 24, 2016

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 24, 2016
@codecov-io
Copy link

codecov-io commented Nov 24, 2016

Current coverage is 3.03% (diff: 100%)

Merging #230 into master will not change coverage

@@            master      #230   diff @@
========================================
  Files           33        33          
  Lines         8107      8107          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7841      7841          
  Partials        20        20          

Powered by Codecov. Last update 3a3782b...ee49342

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 24, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 24, 2016
@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 24, 2016
@thibaultmeyer
Copy link
Contributor

LGTM

@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 24, 2016
@lunny lunny removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2016
@lunny lunny merged commit 6ed7f26 into go-gitea:master Nov 24, 2016
@lunny lunny deleted the lunny/mv_init_from_install branch November 24, 2016 07:40
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Nov 19, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants