-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add sitemap support #18407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add sitemap support #18407
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
18e0f4d
Add sitemap support
danog d88ed16
Fix
danog f6defbb
Revert
danog 4609861
Update routers/web/home.go
danog 0fdf06f
Merge branch 'main' into main
danog 6223fc0
Merge branch 'main' into main
6543 5144750
Update routers/web/home.go
danog b8c18cd
Add sitemap option and constant
danog 14e49ad
Update docs
danog 50ad818
Merge branch 'main' into main
6543 3628523
fix
6543 fb0cec4
Add reference
danog 72ba7e2
Use UTC timezone in tests
danog d59cd6b
Merge branch 'main' into main
6543 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package sitemap | ||
|
||
import ( | ||
"bytes" | ||
"encoding/xml" | ||
"fmt" | ||
"io" | ||
"time" | ||
) | ||
|
||
// sitemapFileLimit contains the maximum size of a sitemap file | ||
const sitemapFileLimit = 50 * 1024 * 1024 | ||
|
||
// Url represents a single sitemap entry | ||
type URL struct { | ||
URL string `xml:"loc"` | ||
LastMod *time.Time `xml:"lastmod,omitempty"` | ||
} | ||
|
||
// SitemapUrl represents a sitemap | ||
type Sitemap struct { | ||
XMLName xml.Name | ||
Namespace string `xml:"xmlns,attr"` | ||
|
||
URLs []URL `xml:"url"` | ||
} | ||
|
||
// NewSitemap creates a sitemap | ||
func NewSitemap() *Sitemap { | ||
return &Sitemap{ | ||
XMLName: xml.Name{Local: "urlset"}, | ||
Namespace: "http://www.sitemaps.org/schemas/sitemap/0.9", | ||
} | ||
} | ||
|
||
// NewSitemap creates a sitemap index. | ||
func NewSitemapIndex() *Sitemap { | ||
return &Sitemap{ | ||
XMLName: xml.Name{Local: "sitemapindex"}, | ||
Namespace: "http://www.sitemaps.org/schemas/sitemap/0.9", | ||
} | ||
} | ||
|
||
// Add adds a URL to the sitemap | ||
func (s *Sitemap) Add(u URL) { | ||
s.URLs = append(s.URLs, u) | ||
} | ||
|
||
// Write writes the sitemap to a response | ||
func (s *Sitemap) WriteTo(w io.Writer) (int64, error) { | ||
if len(s.URLs) > 50000 { | ||
return 0, fmt.Errorf("The sitemap contains too many URLs: %d", len(s.URLs)) | ||
} | ||
buf := bytes.NewBufferString(xml.Header) | ||
if err := xml.NewEncoder(buf).Encode(s); err != nil { | ||
return 0, err | ||
} | ||
if err := buf.WriteByte('\n'); err != nil { | ||
return 0, err | ||
} | ||
if buf.Len() > sitemapFileLimit { | ||
return 0, fmt.Errorf("The sitemap is too big: %d", buf.Len()) | ||
} | ||
return buf.WriteTo(w) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// Copyright 2022 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package sitemap | ||
|
||
import ( | ||
"bytes" | ||
"encoding/xml" | ||
"fmt" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestOk(t *testing.T) { | ||
testReal := func(s *Sitemap, name string, urls []URL, expected string) { | ||
for _, url := range urls { | ||
s.Add(url) | ||
} | ||
buf := &bytes.Buffer{} | ||
_, err := s.WriteTo(buf) | ||
assert.NoError(t, nil, err) | ||
assert.Equal(t, xml.Header+"<"+name+" xmlns=\"http://www.sitemaps.org/schemas/sitemap/0.9\">"+expected+"</"+name+">\n", buf.String()) | ||
} | ||
test := func(urls []URL, expected string) { | ||
testReal(NewSitemap(), "urlset", urls, expected) | ||
testReal(NewSitemapIndex(), "sitemapindex", urls, expected) | ||
} | ||
|
||
ts := time.Unix(1651322008, 0).UTC() | ||
|
||
test( | ||
[]URL{}, | ||
"", | ||
) | ||
test( | ||
[]URL{ | ||
{URL: "https://gitea.io/test1", LastMod: &ts}, | ||
}, | ||
"<url><loc>https://gitea.io/test1</loc><lastmod>2022-04-30T12:33:28Z</lastmod></url>", | ||
) | ||
test( | ||
[]URL{ | ||
{URL: "https://gitea.io/test2", LastMod: nil}, | ||
}, | ||
"<url><loc>https://gitea.io/test2</loc></url>", | ||
) | ||
test( | ||
[]URL{ | ||
{URL: "https://gitea.io/test1", LastMod: &ts}, | ||
{URL: "https://gitea.io/test2", LastMod: nil}, | ||
}, | ||
"<url><loc>https://gitea.io/test1</loc><lastmod>2022-04-30T12:33:28Z</lastmod></url>"+ | ||
"<url><loc>https://gitea.io/test2</loc></url>", | ||
) | ||
} | ||
|
||
func TestTooManyURLs(t *testing.T) { | ||
s := NewSitemap() | ||
for i := 0; i < 50001; i++ { | ||
s.Add(URL{URL: fmt.Sprintf("https://gitea.io/test%d", i)}) | ||
} | ||
buf := &bytes.Buffer{} | ||
_, err := s.WriteTo(buf) | ||
assert.EqualError(t, err, "The sitemap contains too many URLs: 50001") | ||
} | ||
|
||
func TestSitemapTooBig(t *testing.T) { | ||
s := NewSitemap() | ||
s.Add(URL{URL: strings.Repeat("b", sitemapFileLimit)}) | ||
buf := &bytes.Buffer{} | ||
_, err := s.WriteTo(buf) | ||
assert.EqualError(t, err, "The sitemap is too big: 52428931") | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.