Update documentation for reverse proxying static resources #17670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitea fetches static resources from /assets, so nginx configuration has to be updated accordingly.
Gusted
approved these changes
Nov 16, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Nov 16, 2021
GiteaBot
added
lgtm/done
techknowlogick
added
type/docs
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Gitea fetches static resources from /assets, so nginx configuration has to be updated accordingly. Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error in the documentation for setting up nginx reverse proxy with gitea.
Currently, documentation sets the location matching pattern to
/_/static(contents of theSTATIC_URL_PREFIXgitea configuration variable). While this pattern matches the static resource path, it leaves the trailing/assetsat the end. As the instruction only instructs the user to target the gitea frontend in thepublic/directory as the alias target, this results in nginx looking for files inpublic/assets/directory, which doesn't exist.The fix is to change the matching pattern in nginx configuration to consume the
assets/part of the URL path, which results in nginx properly looking for static resources in thepublic/directory.