Skip to content

Remove superfluous argument #17667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

Remove superfluous argument #17667

merged 1 commit into from
Nov 16, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 16, 2021

As title.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2021
@lunny lunny merged commit 447428f into go-gitea:main Nov 16, 2021
@lunny
Copy link
Member

lunny commented Nov 16, 2021

Please send back port to v1.15

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 16, 2021 •
edited
Loading

I think it's not a bug (no affect), backport or not won't affect 1.15, either is fine to me 😊

@Gusted Gusted deleted the js-superflous-arg branch November 16, 2021 11:52
@Gusted
Copy link
Contributor Author

Gusted commented Nov 16, 2021

I think it's not a bug (no affect)

Correct, superfluous arguments in javascript are fine and they won't really effect function executions.

@lunny
Copy link
Member

lunny commented Nov 16, 2021

Hm, any better label do you think we should give it.

@Gusted
Copy link
Contributor Author

Gusted commented Nov 16, 2021

Hm, any better label do you think we should give it.

I personally would label such little code changes under refactoring.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Remove superfluous argument (go-gitea#17667)
fcdd9d5 
As title.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @lunny @wxiaoguang @GiteaBot