Skip to content

Set unit test timeout to 20 minutes #17664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 17, 2021
Merged

Set unit test timeout to 20 minutes #17664

merged 7 commits into from
Nov 17, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 16, 2021 •
edited
Loading

The CI often failed because of 10 minutes timeout, so move to 20 minutes.

silverwind
silverwind approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also just double it to 20m, you can never know for certain how busy the servers are.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
silverwind
silverwind reviewed Nov 16, 2021
View reviewed changes
@lunny @silverwind
Update Makefile
6137263 
Co-authored-by: silverwind <me@silverwind.io>
@lunny lunny changed the title Set unit test timeout to 15 minutes Set unit test timeout to 20 minutes Nov 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2021
@techknowlogick techknowlogick merged commit 42670e6 into go-gitea:main Nov 17, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 17, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Nov 17, 2021
@lunny lunny deleted the lunny/unit_test_timeout branch November 17, 2021 05:27
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @silverwind @techknowlogick
Set unit test timeout to 20 minutes (go-gitea#17664)
c843d39 
* Set unit test timeout to 15 minutes

* Update Makefile

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @silverwind @wxiaoguang @techknowlogick @GiteaBot