Skip to content

Resolve TODO: Enable pagination on GiteaDownloader.GetComments() & update another TODO #16963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 5, 2021

  • Resolve TODO: enable pagination on GiteaDownloader.GetComments()
  • Update TODO: ip.IsPrivate() should be used if minimum go version is dumped to v1.17

to review use: https://github.com/go-gitea/gitea/pull/16963/files?diff=unified&w=1

@6543 6543 added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 5, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #16963 (3f8d2ca) into main (a807031) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16963   +/-   ##
=======================================
  Coverage   45.17%   45.17%           
=======================================
  Files         763      763           
  Lines       86243    86248    +5     
=======================================
+ Hits        38956    38965    +9     
+ Misses      40988    40984    -4     
  Partials     6299     6299           
Impacted Files Coverage Δ
modules/migrations/gitea_downloader.go 0.88% <0.00%> (-0.01%) ⬇️
modules/migrations/migrate.go 27.79% <ø> (ø)
services/pull/pull.go 41.78% <0.00%> (ø)
modules/queue/queue_channel.go 96.66% <0.00%> (+1.66%) ⬆️
modules/queue/queue_bytefifo.go 62.87% <0.00%> (+2.99%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a807031...3f8d2ca. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2021
@6543
Copy link
Member Author

6543 commented Sep 6, 2021

🚀

@6543 6543 merged commit cf6d398 into go-gitea:main Sep 6, 2021
@6543 6543 deleted the todo-nits branch September 6, 2021 16:00
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants