Skip to content

Fix CanCreateRepo check #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Fix CanCreateRepo check #15311

merged 3 commits into from
Apr 7, 2021

Conversation

jolheiser
Copy link
Member

On CreatePost there were a few context keys missing, so returning an error also caused the template to evaluate false-y.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2021
@6543
Copy link
Member

6543 commented Apr 7, 2021

🚀

@6543 6543 merged commit 426ebbf into go-gitea:master Apr 7, 2021
@6543
Copy link
Member

6543 commented Apr 7, 2021

Backport -> #15321

6543 pushed a commit to 6543-forks/gitea that referenced this pull request Apr 7, 2021
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@6543 6543 added the backport/done All backports for this PR have been created label Apr 7, 2021
6543 added a commit that referenced this pull request Apr 7, 2021
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants