Skip to content

Remove raw-loader dependency #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2021
Merged

Remove raw-loader dependency #15112

merged 2 commits into from
Mar 22, 2021

Conversation

silverwind
Copy link
Member

Webpack now includes this functionality, allowing us to drop this now-deprecated dependency.

Ref: https://webpack.js.org/guides/asset-modules/
Ref: https://webpack.js.org/loaders/raw-loader/

@silverwind
Remove raw-loader dependency
be1e3ce 
Webpack now includes this functionality, allowing us to drop this
now-deprecated dependency.

Ref: https://webpack.js.org/guides/asset-modules/
Ref: https://webpack.js.org/loaders/raw-loader/
@silverwind silverwind added dependencies type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 22, 2021
@silverwind
Copy link
Member Author

Actually, file-loader can be removed as well, checking..

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2021
@silverwind silverwind marked this pull request as draft March 22, 2021 18:13
@silverwind
Copy link
Member Author

file-loader can not yet be removed without webpack/webpack#12884 implemented because we need the publicPath option, so this is ready with just the raw-loader removal.

@silverwind silverwind marked this pull request as ready for review March 22, 2021 18:51
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2021
@6543 6543 merged commit 405969c into go-gitea:master Mar 22, 2021
@silverwind silverwind deleted the rmraw branch March 22, 2021 22:56
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lafriks @6543 @GiteaBot