Skip to content

Fix issue reported on #12385 #12969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 28, 2020

Fix missing setting of ConnectionString on getQueueSettings

Fix #12385

Signed-off-by: Andrew Thornton art27@cantab.net

Missed setting ConnectionString on queuesettings

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 28, 2020
@zeripath zeripath added this to the 1.13.0 milestone Sep 28, 2020
@zeripath zeripath self-assigned this Sep 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 28, 2020
@techknowlogick
Copy link
Member

@GaetanJuvin

@codecov-commenter
Copy link

Codecov Report

Merging #12969 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12969      +/-   ##
==========================================
+ Coverage   42.65%   42.70%   +0.04%     
==========================================
  Files         669      669              
  Lines       73494    73495       +1     
==========================================
+ Hits        31350    31387      +37     
+ Misses      37061    37028      -33     
+ Partials     5083     5080       -3     
Impacted Files Coverage Δ
modules/queue/setting.go 45.67% <100.00%> (+0.67%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 40.78% <0.00%> (ø)
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
models/error.go 34.85% <0.00%> (+0.50%) ⬆️
services/mirror/mirror.go 19.86% <0.00%> (+1.34%) ⬆️
modules/indexer/issues/bleve.go 70.71% <0.00%> (+1.42%) ⬆️
services/gitdiff/gitdiff.go 74.48% <0.00%> (+1.63%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb1a8c...4136b05. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2020
@techknowlogick techknowlogick merged commit 5cfc1f5 into go-gitea:master Sep 28, 2020
@zeripath zeripath deleted the fix-12385-connection-string-not-passed-on branch September 29, 2020 06:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants