Skip to content

Use cli Flags directly and not some helper funcs #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Use cli Flags directly and not some helper funcs #127

merged 2 commits into from
Nov 10, 2016

Conversation

metalmatze
Copy link
Contributor

We can just use those flags directly. No need to use a helper func.

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
@codecov-io
Copy link

codecov-io commented Nov 9, 2016

Current coverage is 3.14% (diff: 100%)

Merging #127 into master will not change coverage

@@            master      #127   diff @@
========================================
  Files           33        33          
  Lines         7823      7823          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7557      7557          
  Partials        20        20          

Powered by Codecov. Last update 475ddd8...90fb64b

@andreynering
Copy link
Contributor

LGTM

1 similar comment
@lunny
Copy link
Member

lunny commented Nov 10, 2016

LGTM

@lunny lunny merged commit 145648a into go-gitea:master Nov 10, 2016
@lunny lunny removed the in progress label Nov 10, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 10, 2016
@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 10, 2016
@metalmatze metalmatze deleted the enhancement/cli branch November 10, 2016 08:48
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jan 5, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants