Skip to content

(Enhancement) Add "Review Required" Identifier on Pull Requests Targeting Protected Branches with Required Approvals #8257

Closed
@bagasme

Description

@bagasme
  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant (I couldn't access because of slow internet connection)
  • Log gist:
    (not relevant)

Description

In Pull Requests tab of Gitea repository, there isn't Review Required text next to who and when the pull request that merge into protected branch with required approvals setting was made. Thus, users don't know whether a PR requires reviews/approvals without having to click into individual PR link.

Screenshots

This screenshot below is from my localhost Gitea instance on my computer. I created learnPRHomework repository and set master branch protected with 1 required approval. Other user (bagas) open a pull request to this protected branch. Note that there isn't Review Required text as described in the description above:
Screenshot_2019-09-22 learnPRHomework

On the other hand, PR on GitHub with similar condition have Review Required text (the screenshot is from linode-docs PRs:
Screenshot_2019-09-22 linode docs

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/enhancementAn improvement of existing functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions