Panic during clone over SSH with sqlite3 driver

[lnicola]

• Gitea version: 1.0.1
• Git version: 2.11.0
• Operating system: Arch Linux
• Database:
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:
  https://gist.github.com/lnicola/84cd40c22174d4febe13da83e8c61340

Description

PostgreSQL works fine for me, but I can reproduce this for SQLite on a new install.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[lnicola]

On the other hand, it doesn't happen with the official Docker image running 1.0.0+148-g521d429b.

[lunny]

I cannot reproduce it. It seems your sqlite db doesn't config correctly. Maybe a permission problem. Where did you put the db?

[lnicola]

@lunny Did you test with master or the 1.0.1 release? It might have been fixed in the meanwhile since the Docker image worked for me.

I just tried it, the git user is able to read and modify the database.

[lunny]

I have tested both master and 1.0.1 with sqlite. All are OK.

[lnicola]

That's strange, I'm using the Arch Linux AUR package. I still think it's fixed, but can we leave this open until the next release?

[lunny]

OKay!

[bkcsoft]

I see two errors in those logs, 1) panic (obviously) 2) xorm doesn't log before it runs the command 😉

[lunny]

The panic is because x is nil. On serv command , setup("serve.log") doesn't return an error and also the error is not recorded. I will send a PR to let setup return the error and log it.

[lunny]

@lnicola could you cherry-pick #932 to v1.0.1 and build from source to see the reason of panic?

[lnicola]

@lunny I'm not sure how to build it :(.

$ git checkout v1.0.1
$ TAGS="bindata sqlite" make generate build
go generate code.gitea.io/gitea code.gitea.io/gitea/cmd code.gitea.io/gitea/models code.gitea.io/gitea/models/migrations code.gitea.io/gitea/modules/auth code.gitea.io/gitea/modules/auth/ldap code.gitea.io/gitea/modules/auth/pam code.gitea.io/gitea/modules/avatar code.gitea.io/gitea/modules/base code.gitea.io/gitea/modules/context code.gitea.io/gitea/modules/cron code.gitea.io/gitea/modules/highlight code.gitea.io/gitea/modules/httplib code.gitea.io/gitea/modules/log code.gitea.io/gitea/modules/mailer code.gitea.io/gitea/modules/markdown code.gitea.io/gitea/modules/options code.gitea.io/gitea/modules/process code.gitea.io/gitea/modules/public code.gitea.io/gitea/modules/setting code.gitea.io/gitea/modules/ssh code.gitea.io/gitea/modules/sync code.gitea.io/gitea/modules/templates code.gitea.io/gitea/modules/user code.gitea.io/gitea/routers code.gitea.io/gitea/routers/admin code.gitea.io/gitea/routers/api/v1 code.gitea.io/gitea/routers/api/v1/admin code.gitea.io/gitea/routers/api/v1/convert code.gitea.io/gitea/routers/api/v1/misc code.gitea.io/gitea/routers/api/v1/org code.gitea.io/gitea/routers/api/v1/repo code.gitea.io/gitea/routers/api/v1/user code.gitea.io/gitea/routers/dev code.gitea.io/gitea/routers/org code.gitea.io/gitea/routers/repo code.gitea.io/gitea/routers/user
bindata.go
bindata.go
bindata.go
go build -v -tags 'bindata sqlite' -ldflags '-s -w -X "main.Version=1.0.1"' -o gitea
code.gitea.io/gitea/vendor/github.com/Unknwon/com
code.gitea.io/gitea/vendor/github.com/mcuadros/go-version
code.gitea.io/gitea/modules/log
code.gitea.io/gitea/modules/user
code.gitea.io/gitea/vendor/github.com/bradfitz/gomemcache/memcache
code.gitea.io/gitea/vendor/github.com/go-macaron/inject
code.gitea.io/gitea/vendor/gopkg.in/ini.v1
code.gitea.io/gitea/vendor/gopkg.in/bufio.v1
code.gitea.io/gitea/vendor/github.com/kardianos/minwinsvc
code.gitea.io/gitea/vendor/strk.kbt.io/projects/go/libravatar
code.gitea.io/gitea/vendor/github.com/gogits/chardet
code.gitea.io/gitea/vendor/gopkg.in/redis.v2
code.gitea.io/gitea/vendor/code.gitea.io/git
code.gitea.io/gitea/vendor/github.com/go-xorm/builder
code.gitea.io/gitea/vendor/gopkg.in/macaron.v1
code.gitea.io/gitea/vendor/github.com/Unknwon/i18n
code.gitea.io/gitea/vendor/github.com/go-xorm/core
code.gitea.io/gitea/vendor/github.com/satori/go.uuid
code.gitea.io/gitea/vendor/gopkg.in/asn1-ber.v1
code.gitea.io/gitea/vendor/gopkg.in/ldap.v2
code.gitea.io/gitea/vendor/github.com/go-macaron/cache
code.gitea.io/gitea/vendor/github.com/go-macaron/session
code.gitea.io/gitea/vendor/github.com/go-macaron/cache/memcache
code.gitea.io/gitea/vendor/github.com/go-macaron/cache/redis
code.gitea.io/gitea/vendor/github.com/go-xorm/xorm
code.gitea.io/gitea/modules/auth/ldap
code.gitea.io/gitea/modules/auth/pam
code.gitea.io/gitea/vendor/github.com/issue9/identicon
code.gitea.io/gitea/modules/httplib
code.gitea.io/gitea/modules/avatar
code.gitea.io/gitea/vendor/golang.org/x/net/html/atom
code.gitea.io/gitea/vendor/golang.org/x/net/html
code.gitea.io/gitea/vendor/github.com/go-macaron/session/redis
code.gitea.io/gitea/vendor/gopkg.in/gomail.v2
code.gitea.io/gitea/modules/setting
code.gitea.io/gitea/vendor/github.com/shurcooL/sanitized_anchor_name
code.gitea.io/gitea/vendor/github.com/russross/blackfriday
code.gitea.io/gitea/modules/base
code.gitea.io/gitea/modules/highlight
code.gitea.io/gitea/vendor/github.com/jaytaylor/html2text
code.gitea.io/gitea/vendor/github.com/microcosm-cc/bluemonday
code.gitea.io/gitea/modules/mailer
code.gitea.io/gitea/modules/options
code.gitea.io/gitea/modules/markdown
code.gitea.io/gitea/modules/process
code.gitea.io/gitea/modules/sync
code.gitea.io/gitea/vendor/code.gitea.io/sdk/gitea
code.gitea.io/gitea/vendor/github.com/Unknwon/cae
code.gitea.io/gitea/vendor/github.com/Unknwon/cae/zip
code.gitea.io/gitea/vendor/github.com/go-macaron/binding
code.gitea.io/gitea/vendor/github.com/go-sql-driver/mysql
code.gitea.io/gitea/vendor/github.com/lib/pq/oid
code.gitea.io/gitea/vendor/github.com/lib/pq
code.gitea.io/gitea/vendor/github.com/mattn/go-sqlite3
code.gitea.io/gitea/models/migrations
code.gitea.io/gitea/vendor/github.com/nfnt/resize
code.gitea.io/gitea/vendor/github.com/sergi/go-diff/diffmatchpatch
code.gitea.io/gitea/vendor/golang.org/x/crypto/pbkdf2
code.gitea.io/gitea/vendor/golang.org/x/crypto/curve25519
code.gitea.io/gitea/vendor/golang.org/x/crypto/ed25519/internal/edwards25519
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/internal/identifier
code.gitea.io/gitea/vendor/golang.org/x/text/transform
code.gitea.io/gitea/vendor/golang.org/x/text/internal/utf8internal
code.gitea.io/gitea/vendor/golang.org/x/text/encoding
code.gitea.io/gitea/vendor/golang.org/x/text/runes
code.gitea.io/gitea/vendor/golang.org/x/text/internal/tag
code.gitea.io/gitea/vendor/golang.org/x/text/language
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/internal
code.gitea.io/gitea/vendor/golang.org/x/crypto/ed25519
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/charmap
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/japanese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/korean
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/simplifiedchinese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/traditionalchinese
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/unicode
code.gitea.io/gitea/vendor/github.com/Unknwon/paginater
code.gitea.io/gitea/vendor/github.com/go-macaron/csrf
code.gitea.io/gitea/vendor/github.com/go-macaron/i18n
code.gitea.io/gitea/vendor/gopkg.in/editorconfig/editorconfig-core-go.v1
code.gitea.io/gitea/vendor/golang.org/x/text/encoding/htmlindex
code.gitea.io/gitea/vendor/github.com/elazarl/go-bindata-assetfs
code.gitea.io/gitea/vendor/github.com/gogits/cron
code.gitea.io/gitea/vendor/golang.org/x/net/html/charset
code.gitea.io/gitea/vendor/github.com/go-macaron/captcha
code.gitea.io/gitea/vendor/github.com/go-macaron/bindata
code.gitea.io/gitea/modules/public
code.gitea.io/gitea/vendor/github.com/klauspost/cpuid
code.gitea.io/gitea/vendor/github.com/klauspost/crc32
code.gitea.io/gitea/vendor/github.com/go-macaron/toolbox
code.gitea.io/gitea/vendor/github.com/klauspost/compress/flate
code.gitea.io/gitea/vendor/github.com/urfave/cli
code.gitea.io/gitea/vendor/github.com/klauspost/compress/gzip
code.gitea.io/gitea/vendor/github.com/go-macaron/gzip
# code.gitea.io/gitea/modules/public
modules/public/static.go:23: undefined: AssetInfo
code.gitea.io/gitea/models
code.gitea.io/gitea/modules/auth
code.gitea.io/gitea/modules/templates
code.gitea.io/gitea/modules/cron
code.gitea.io/gitea/modules/ssh
code.gitea.io/gitea/routers/api/v1/convert
# code.gitea.io/gitea/modules/templates
modules/templates/static.go:37: undefined: AssetInfo
code.gitea.io/gitea/modules/context
code.gitea.io/gitea/routers/api/v1/misc
code.gitea.io/gitea/routers/dev
make: *** [Makefile:87: gitea] Error 2