Custom templates doesn't work

[gdudas]

• Gitea version (or commit ref): v1.0.0+34-gac51caa
• Git version: 2.8.3
• Operating system: Linux amd64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Adding a custom template under custom/templates doesn't work.

Thomas Boerger @tboerger 14:29
let me check the macaron renderer source
looks like we need to implement a custom TemplateFileSystem because AppendDirectories gets ignored by the bindata based TemplateFileSystem from https://github.com/go-macaron/bindata

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/40471993-custom-templates-doesn-t-work?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

[strk]

For reference, this was known before the bug was introduced here:
#314 (comment)

Should be only when bindata build tag is used.

[esell]

Just curious, if we are using the download from the "master" directory here: https://dl.gitea.io/gitea/master/ are custom templates expected to work? I'm a little lost with the dialog as to if the issue has been resolved or if it's still pending. Thanks!

[strk]

Issue is still pending for builds with 'bindata' tag. The downloads from dl.gitea.io are of this kind (so broken). I guess it would help to include the build tags in the version string as printed by some footers, btw.

[esell]

I actually was just coming back to edit my first post haha. I just realized the difference between bindata builds and non-bindata builds by RTFM and get it now, thanks for the quick response though!

[tboerger]

We will resolve this issue for 1.1

[lunny]

@tboerger any update?

[tboerger]

I will work on this within this week hopefully, but let's stop backporting that.