gitea panics on a markdown syntax error (nested links)

[earwig]

• Gitea version (or commit ref): master (acb6f8a), also 1.5.1
• Git version: Tested 2.10.1, 2.18.0
• Operating system: Tested Ubuntu, macOS
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL): https://try.gitea.io/earwig/markuptest
  • No
  • Not relevant
• Log gist: https://gist.github.com/earwig/f44165540933bbe277a4704136ba80b9

Description

The syntax is this: [\[\[foobar\]\]](https://example.org)

Expected result: [[foobar]]

I noticed it when trying to mirror one of my repos.

[SagePtr]

I don't get why "visitLinksForShortLinks" logic in modules/markup/html.go is used, where it's used at all. Why nested links should be processed, any working example where they are needed. I cannot remember any example where <a> tag is included into another <a> tag in production, and how the broswers should handle this mess.
Probably over-engeneering?

[earwig]

Agreed, I looked through the code myself while trying to debug and couldn’t understand it either. None of tests seem to go through that code path, unless I’m missing something.

…

On Sep 19, 2018, at 4:54 PM, SagePtr ***@***.***> wrote: I don't get why "visitLinksForShortLinks" logic in modules/markup/html.go is used, where it's used at all. Why nested links should be processed, any working example where they are needed. Probably over-engeneering? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[earwig]

This bug still causes an uncaught internal server error in production, as you can see from the reproduction I linked in the original post. This issue should not be closed.