Compare button on upstream repo leads to 404

[mxmehl]

• Gitea version (or commit ref): 1.4.0
• Git version: 2.1.4
• Operating system: Debian 8
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant: does not work

Description

Scenario: I, user joe, forked repository repo of another user called upstream.

Now, if I am on joe/repo and click on the green compare button, everything works as expected and I see the "Compare Changes" window. However, this doesn't work on upstream/repo, there I see a 404 error.

I noted that the 404 does not appear if I'm owner of the upstream repository's organisation.

The links of the button look like this:

https://git.example.org/upstream/repo/compare/master...joe:master from forked repo -> works
https://git.example.org/upstream/repo/compare/master...upstream:master from upstream repo -> doesn't work

I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before.

I cannot check how the links looked like in 1.3, but I was told by a user on my Gitea instance that it worked before.

I can confirm that.

[lafriks]

Does link https://git.example.org/upstream/repo/compare/master...master work?

[mxmehl]

Does link https://git.example.org/upstream/repo/compare/master...master work?

No, this also generates an 404. As repo or organisation owner it seems to work though.

[lafriks]

What rights does user joe does for upstream repo? Is it private or public?

Please note that the 'New Pull Request' button in the Pull Requests tab works perfectly and generates this link:

https://git.example.org/upstream/repo/compare/master...joe:master

[mxmehl]

What rights does user joe does for upstream repo? Is it private or public?

No specific permissions (i.e. no organisation or team member, or collaborator). The repo is public.

[Infern1]

Seeing the same problem

When clicking pull request this url is generated

http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...my_username:master

and returns a 404
If I change the url to
http://git.server.com/git/APCS-WEB/WEB_MasterLmpc/compare/master...develop

it works

Isn't this same error, fixed:
gogs/gogs@afab38b
?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[adelowo]

Sent a PR for this already