Repository Size Limit

[jonasfranz]

It would be nice if it possible to set a global or user repository size limit. This would be good for Gitea providers providing Gitea for the public with limited disk space to have this option as mentioned in #1029 .

Approaches for restricting repo size

Solution 1

• User gets a notification if a repository exceeded the size limit
• Admin gets a notification if a repository exceeded the size limit (optional)
• Repository gets deleted (after a ultimatum) if a user did not reduced the size of the repository

Solution 2

• The size of every push gets approved (I don't know if that is possible or realistic) and blocked if the push is to large

[sbrl]

Suggestion: Have a warning limit too. That way users are warned when they are, say, 80% full - so they've got some time to do something about it.

[kolaente]

I'd prefer the second solution + warning. It doesn't seem practical to completely delete a users repo if it is past the size limit.

[jonasfranz]

@kolaente Do you have an idea who to calculate the size of a push before it is finished?

[sapk]

@JonasFranzDEV seems possible with a pre-receive hook that check size (cat-files) of the commit object. For examples : https://github.com/github/platform-samples/tree/master/pre-receive-hooks & https://stackoverflow.com/questions/40697663/show-commit-size-in-git-log

[jonasfranz]

@sapk Thank you for the hint. It seems that size, err := git.GetRepoSize(repoPath) will return the size of the repository including the newest push if it is called at pre-receive.

How should the size limit work?

1. Global size limit via the config file for all repositories
2. Custom size limit for repositories and a default value from the config file
   a. How can change the limit of a repository and how? I propose the admin but I do not know if the admin panel or the repository settings are the right place to do this?
3. Size limit per user via config file with the option the change the size limit via the admin panel like it is possible for the number of repositories. (user administration)

Other proposals are welcome too!

[techknowlogick]

We could have a combination of the above, a global size limit to make sure that the disk doesn't run out of space, and a per user limit (in the case of some git hosts they say each user gets 1GB or something).

[jonasfranz]

@techknowlogick Should a push (no matter which user) be restricted/denied, if the global size limit is exceeded?

[lafriks]

I don't think 1st one is needed but would be great if it was combination of 2nd and 3rd. With defaults in config and custom values stored in repo and user tables with 0 being that default value limit should be applied and -1 that there is no limit

[lafriks]

Oh one more thing - should LFS be counted and if so than that should probably be done seperetly

[jonasfranz]

@lafriks

How can change the limit of a repository and how? I propose the admin but I do not know if the admin panel or the repository settings are the right place to do this?

[lafriks]

@JonasFranzDEV for user limit in user editing in admin panel. For repository there is now also a admin specific option in repo settings already

[sapk]

Also what happen when a user try to push to an org ? or did we consider org like a distinct user ?

[lafriks]

I would say that org should be treated as separate user

[techknowlogick]

I don't think we should rely on just 2 & 3 as perhaps if you don't want to limit the number of users but you want to make sure you don't run out of space, then a global limit would be needed (ex. try.gitea.io runs out of space and if a user maxes out their space you don't want to encourage them to create an additional account). This is especially possible with an open gitea instance.

Regarding what we should do when the limit is reached, there are two options that I see:

1. show warnings in the git push prompt, and perhaps raise the warning is system messages of admin panel
2. reject push

or have two limits: soft (1), and hard (2)