Closed
Description
Description
I believe AggregateJobStatus works incorrectly. First found and reported in fork.
Currently aggregation can return one of 4 states for a job:
- Failure if all jobs are done and one is a fail
- Success if all jobs are done and none failed
- Waiting if none are running or done
- Finally running if none of the above apply
It ignores cancellations, blocks and skips completely despite those being states which might represent the run best - such as skip as an aggregate result when all jobs are completed and were skipped.
Rough reproducer is at: https://demo.gitea.com/TheFox0x7/bad-aggregation/actions and the github version https://github.com/TheFox0x7/repro.
Gitea Version
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
I used demo site to demonstrate the issue.
Database
None