Protected branches system

[DblK]

One missing feature from gogs is a way to protect branches like Github does.
After the completion of the API implementation, we could easily add application like Drone to check the PR.

The UI need to be changed to add options to protect branches like this:

I suggest to add some columns in table (don't know how many yet) to store those options.
The "Merge" button from a PR should be activated is the conditions are not matched.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[tboerger]

Please don't prefix the issue with [Feature], that should be done via labels. This is an important feature for an lgtm.co integration, so a big 👍 for that.

[lunny]

I think this need a proposal to describe it.

[bkcsoft]

@lunny Agreed. I've looked into this issue before, and it requires a rewrite of how GitHooks are currently Exposed.

Reference: gogs/gogs#776 (comment)

[strk]

@DblK "proposal" proposed process is here https://github.com/go-gitea/proposals/pull/1

[thibaultmeyer]

+1 without protected branches system, Gitea will be not ready for a corporate environment where is not acceptable to ask at each developers to use the "fork and pull request" flow.

[lunny]

Before we can start protected branch, we have to finish the dependent features first:

• code review, this is based comment on code, but add a flag to disable merge button until the comment author close it.
• status check system, this is based webhook. and it's a specific webhook. We could define it like github.
• rebase the PR.

Implement every one feature will not result many commits, so we can do it step by step.
Welcome to improve it.

[Ritbit]

+1 desperately in need for this.

[bkcsoft]

@lunny no need for all that, just a simple branch X can't be pushed to would suffice to start with 🙂

As for status check, that would be fairly simple to implement really (if one does as GitHub API does)