"Show changes since your last review" button should still show even if a review was requested from me again

[Gr3q]

Description

A PR "Files Changed" tab's "Filter by commit" button's "Show changes since your last review" sub button should still show even if a review was requested from me again after my review. Note that the previous review was not dismissed.

My guess is that the logic only looks at the top of the review stack of a person, and when a request is on top it just skips the part where it works out the difference.

Gitea Version

1.21.11

Can you reproduce the bug on the Gitea demo site?

No, because I need 2 account for that, but I'll do that when I have time.

Log Gist

No response

Screenshots

Before a new review was requested of me

After a new review was requested of me

Git Version

No response

Operating System

Ubuntu 22.04

How are you running Gitea?

self-hosted docker image

Database

None

[Zettat123]

Your guess is correct. A review request is a special type of review.

gitea/models/issues/review.go

Lines 101 to 102 in 3269b04

	// ReviewTypeRequest request review from others
	ReviewTypeRequest

When we create a review request, we do not need to specify the commit ID.

gitea/models/issues/review.go

Lines 692 to 698 in 3269b04

	review, err = CreateReview(ctx, CreateReviewOptions{
	Type: ReviewTypeRequest,
	Issue: issue,
	Reviewer: reviewer,
	Official: official,
	Stale: false,
	})

Therefore, when the latest review is a review request, the commit ID will be empty, which will cause the "Show changes since your last review" button to not show.

To fix this issue, I think we should improve the logic of querying the latest review. In this case, we should try to get the latest review whose commit ID is not empty.