The usage of `NewRequestWithValues(t, "PATCH", url, data)` doesn't work in tests

[yp05327]

Description

PATCH request will read data from Form, but NewRequestWithValues will insert data into Body, so these data will not be readed correctly.
As title, the usage of NewRequestWithValues(t, "PATCH", url, data) doesn't work in tests

e.g.

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

[yp05327]

theObj is empty, so in this function, we will always set empty data. But ctx.Req.Form has the data, so maybe something changed?

[yp05327]

NewRequestWithJSON works but NewRequestWithValues doesn't work.

[yp05327]

For Form, if the type of the field is *string, it doesn't work, but if it is string, it works.

[yp05327]

@lunny
It seems that this issue is because gitea.com/go-chi/binding doesn't support non-struct pointer.
https://gitea.com/go-chi/binding/pulls/5

[yp05327]

Any plan to finish it, API requests with form type body can not be applied correctly which looks like a big bug.

[lunny]

https://gitea.com/go-chi/binding/pulls/5 merged.

[yp05327]

Then the next step is adding result checking in theses tests to confirm whether it works.

[lunny]

Can you help to send a PR?

[yp05327]

It seems that it does not work. Still got empty items.
I will send a PR to test it first, then let's fix it.

[yp05327]

@lunny
the origin PR is not enough, created a new one to fix this issue:
https://gitea.com/go-chi/binding/pulls/16