RSS feeds.Item.id is not a valid URL and is not isPermalink=false

[beaucollins]

Description

When creating the RSS feed for releases, the Item.id is set to a db ID value with the url concatenated. Example:

      <guid>316519: https://gitea.com/owner/repo/releases/tag/v2.4.1rc1</guid>

gitea/routers/web/feed/convert.go

Line 308 in f4ea8d9

Id: fmt.Sprintf("%v: %v", strconv.FormatInt(rel.ID, 10), link.Href),

The RSS 2 standard states:

guid stands for globally unique identifier. It's a string that uniquely identifies the item. When present, an aggregator may choose to use this string to determine if an item is new.

There are no rules for the syntax of a guid. Aggregators must view them as a string. It's up to the source of the feed to establish the uniqueness of the string.

If the guid element has an attribute named isPermaLink with a value of true, the reader may assume that it is a permalink to the item, that is, a url that can be opened in a Web browser, that points to the full item described by the element. An example:

isPermaLink is optional, its default value is true. If its value is false, the guid may not be assumed to be a url, or a url to anything in particular.

https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt

And since the default value of true indicates this is a valid URL gitea should provide a valid URL or set isPermalink="false".

Gitea's behavior of providing an invalid URL and leaving out the isPermalink="false" it breaks some feed readers that expect the <guid> to abide by the RSS 2.0 specification.

Gitea Version

1.22.0+dev-522-ga04f8c0f8

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

https://gitea.com/

Database

None

[beaucollins]

The package Gitea uses to create the RSS feeds does not seem to support setting isPermalink. Relevant issue gorilla/feeds#78

Seems the simplest fix code wise would be to append the id as a URL fragment https://url.com/org/repo/feed#123456 but this would cause all existing feeds to indicate that the feed item is new since the GUID will have changed.

[yardenshoham]

I mentioned this in #21550 (comment)

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines